Avoid exceptions from hermetic sandbox for unsupported artifact subclasses #16739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue subclasses. Also adds test cases to confirm no regression of existing functionality. Fixes 15340
|
Hi @larsrc-google. Here is a fix for #15340. What do you think? |
ShreeM01
added
team-Local-Exec
larsrc-google
approved these changes
Nov 11, 2022
Change-Id: I0f1373f6f99328b8277fe1cec87d3946b83481c1
|
Thanks @larsrc-google for quick feedback! I now updated according to your comments. Is there anything more you would like me to do? |
larsrc-google
approved these changes
Nov 16, 2022
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
lunch-glide-pepper
pushed a commit
to lunch-glide-pepper/bazel
that referenced
this pull request
Nov 23, 2022
…asses Avoid exceptions from linux hermetic sandbox for unsupported FileArtifactValue subclasses. Also adds test cases to confirm no regression of existing functionality. Fixes bazelbuild#15340 Closes bazelbuild#16739. Change-Id: I0f1373f6f99328b8277fe1cec87d3946b83481c1 PiperOrigin-RevId: 490490477
lunch-glide-pepper
pushed a commit
to lunch-glide-pepper/bazel
that referenced
this pull request
Nov 23, 2022
…asses Avoid exceptions from linux hermetic sandbox for unsupported FileArtifactValue subclasses. Also adds test cases to confirm no regression of existing functionality. Fixes bazelbuild#15340 Closes bazelbuild#16739. Change-Id: I0f1373f6f99328b8277fe1cec87d3946b83481c1 PiperOrigin-RevId: 490490477
|
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Dec 1, 2022
…asses (#16830) Avoid exceptions from linux hermetic sandbox for unsupported FileArtifactValue subclasses. Also adds test cases to confirm no regression of existing functionality. Fixes #15340 Closes #16739. Change-Id: I0f1373f6f99328b8277fe1cec87d3946b83481c1 PiperOrigin-RevId: 490490477 Co-authored-by: Ulrik Falklof <[email protected]> Co-authored-by: kshyanashree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid exceptions from linux hermetic sandbox for unsupported FileArtifactValue subclasses.
Also adds test cases to confirm no regression of existing functionality.
Fixes #15340